Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8248403: AArch64: Remove uses of kernel integer types #246

Closed
wants to merge 1 commit into from
Closed

8248403: AArch64: Remove uses of kernel integer types #246

wants to merge 1 commit into from

Conversation

phohensee
Copy link
Member

@phohensee phohensee commented Aug 13, 2021 •
edited by openjdk bot

Backport applies cleanly net of context differences. Testing: tier1.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8248403: AArch64: Remove uses of kernel integer types

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/246/head:pull/246
$ git checkout pull/246

Update a local copy of the PR:
$ git checkout pull/246
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/246/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 246

View PR using the GUI difftool:
$ git pr show -t 246

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/246.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 13, 2021

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6a91c73dda1cb197d74f0cb3b491d9c47f4bb40c 8248403: AArch64: Remove uses of kernel integer types Aug 13, 2021
@openjdk
Copy link

openjdk bot commented Aug 13, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 13, 2021 •
edited

@phohensee This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8248403: AArch64: Remove uses of kernel integer types

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 13, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 13, 2021

Webrevs

@phohensee phohensee mentioned this pull request Aug 13, 2021
Closed
3 tasks
tstuefe
tstuefe approved these changes Aug 14, 2021
View reviewed changes
Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phohensee
Copy link
Member Author

Thank you, Thomas. Tagged.

@phohensee
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 16, 2021

Going to push as commit 5ce46d9.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 3db0637: 8272197: Update 11u GHA workflow with Shenandoah configurations
  • 55545f4: 8225082: Remove IdenTrust certificate that is expiring in September 2021
  • 12312a3: 8230841: Remove oopDesc::equals()
  • 8a470e1: 8209768: Refactor java/util/prefs/CheckUserPrefsStorage.sh to plain java test
  • 8738bb5: 8213409: Refactor sun.text.IntHashtable:i18n shell tests to plain java tests
  • 2c3f99d: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open
  • 80972c5: 8214520: [TEST_BUG] sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java failed with incorrect jtreg tags order
  • ac8510b: 8262862: Harden tests sun/security/x509/URICertStore/ExtensionsWithLDAP.java and krb5/canonicalize/Test.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 16, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 16, 2021
@openjdk
Copy link

openjdk bot commented Aug 16, 2021

@phohensee Pushed as commit 5ce46d9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@phohensee phohensee deleted the backport-6a91c73d branch August 16, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstuefe tstuefe tstuefe approved these changes

Assignees
No one assigned
Labels
backport clean integrated Pull request has been integrated
Milestone
No milestone
2 participants
@phohensee @tstuefe